adriangb commented on code in PR #22680: URL: https://github.com/apache/datafusion/pull/22680#discussion_r3338106069
########## benchmarks/sql_benchmarks/imdb/init/cleanup.sql: ########## @@ -0,0 +1,41 @@ +DROP TABLE aka_name; + +DROP TABLE aka_title; + +DROP TABLE cast_info; + +DROP TABLE char_name; + +DROP TABLE comp_cast_type; + +DROP TABLE company_name; + +DROP TABLE company_type; + +DROP TABLE complete_cast; + +DROP TABLE info_type; + +DROP TABLE keyword; + +DROP TABLE kind_type; Review Comment: I see no harm in using `IF EXISTS`. It's just a defense in depth against confusing error messages if things fail. Wdyt @Omega359 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
