martin-g commented on code in PR #1742:
URL:
https://github.com/apache/datafusion-ballista/pull/1742#discussion_r3340765796
##########
ci/scripts/rust_clippy.sh:
##########
@@ -18,4 +18,11 @@
# under the License.
set -ex
-cargo clippy --all-targets --workspace --all-features -- -D warnings
Review Comment:
Because the -cli crate cannot be built with `--all-features`:
```
error: 'tui' and 'web' features cannot be enabled at the same time!
--> ballista-cli/src/lib.rs:21:1
|
21 | compile_error!("'tui' and 'web' features cannot be enabled at the same
time!");
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
I could have used `cargo clippy --workspace --exclude ballista-cli` but the
approach I took in this PR exposed some issue in the `examples` crate that was
not failing with `--workspace` for some reason.
https://github.com/apache/datafusion-ballista/pull/1742/changes/4f82b40dae4982f4d2b9fb99f857636bed67a367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
