parthchandra commented on PR #756:
URL: https://github.com/apache/datafusion-comet/pull/756#issuecomment-2263874773
Micro Benchmark numbers -
```
Running benchmark: TPCDS Micro Benchmarks
Running case: scan_decimal
Stopped after 10 iterations, 57040 ms
Running case: scan_decimal: Comet (Scan)
24/08/01 12:22:30 INFO core/src/lib.rs: Comet native library initialized
Stopped after 10 iterations, 49922 ms
Running case: scan_decimal: Comet (Scan) Decimal 128 enabled
Stopped after 10 iterations, 56649 ms
Running case: scan_decimal: Comet (Scan, Exec)
Stopped after 10 iterations, 49928 ms
OpenJDK 64-Bit Server VM 11.0.19+7-LTS on Mac OS X 14.6
Apple M3 Max
TPCDS Micro Benchmarks: Best Time(ms) Avg
Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
-------------------------------------------------------------------------------------------------------------------------------
scan_decimal 5676
5704 22 0.5 1971.0 1.0X
scan_decimal: Comet (Scan) 4973
4992 23 0.6 1726.9 1.1X
scan_decimal: Comet (Scan) Decimal 128 enabled 5652
5665 9 0.5 1962.7 1.0X
scan_decimal: Comet (Scan, Exec) 4964
4993 19 0.6 1723.9 1.1X
```
Previously
`scan_decimal: Comet (Scan) Decimal 128 enabled` was 0.5x of `scan_decimal`
This brings Decimals in CometVector at parity with Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
