albertlockett commented on PR #22647: URL: https://github.com/apache/datafusion/pull/22647#issuecomment-4611225241
> > > Is it a common use case to be constructing the physical expression directly without going through the logical optimizer which handles signature coercion? > > > > > > I can't speak to how common it is generally -- but this is what what is done in the codebase I work on. > > Currently we are working around this casting the dictionary arrays to a UTF-8 array before invoking the expression. We'd like to avoid doing this unnecessary conversion. > > With the changes introduced in this PR, I imagine you'd also be able to avoid the cast added by the optimizer's coercsion, which maybe you find interesting from a performance perspective as well. > > What I'm trying to highlight is this PR only adds this path for physical execution; meaning it is unreachable via normal SQL execution which goes through the optimizer path because the signature of the UDFs still coerce away from dictionary (hence why I wanted an end-to-end SLT example to prove this works). Also, taking another look, this physical execution path is implemented only for the array path and misses out the scalar path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
