andygrove opened a new pull request, #4583:
URL: https://github.com/apache/datafusion-comet/pull/4583

   ## Which issue does this PR close?
   
   N/A. This is a documentation/tooling change to reduce contributor friction.
   
   ## Rationale for this change
   
   `docs/source/user-guide/latest/expressions.md` is hand-edited by nearly 
every PR that adds or updates a Spark expression. The tables are formatted by 
prettier, which aligns each column to its widest cell. Adding a single row 
whose `Notes` (or any) cell is wider than the current column re-pads every 
other row in that table. The result is large, noisy diffs and frequent merge 
conflicts between concurrent expression PRs that each touch the same table.
   
   ## What changes are included in this PR?
   
   - Add a `.prettierignore` that exempts 
`docs/source/user-guide/latest/expressions.md`. The file is almost entirely 
tables, and prettier's markdown prose handling is whitespace-only (`proseWrap` 
defaults to `preserve`), so exempting the whole file costs nothing for the 
surrounding prose while stopping the column re-padding.
   - Collapse the existing table padding to single spaces. With prettier no 
longer aligning the tables, removing the alignment padding means adding a row 
never shifts the other rows. Combined with the prettier exemption, every future 
addition is a true one-line diff that cannot collide on re-alignment. This is a 
one-time reformat (470 rows) with no content changes.
   
   ## How are these changes tested?
   
   Verified locally that `prettier --check "**/*.md"` passes with the file 
ignored (including after appending a deliberately misaligned row), and that all 
20 tables retain consistent column counts after the reformat, with the 
escaped-pipe cell (`` `\|` `` in `bitwise_funcs`) preserved.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to