haohuaijin opened a new pull request, #22752: URL: https://github.com/apache/datafusion/pull/22752
## Which issue does this PR close? - Closes #. ## Rationale for this change The config `skip_partial_aggregation_probe_ratio_threshold` was documented as triggering skip when the ratio is **greater than** the threshold, but the code used `>=`. This meant setting the threshold to `1.0` (to disable the feature) still skipped rows when cardinality was exactly 100%. ## What changes are included in this PR? - Changed `>=` to `>` in the ratio comparison to match the docs. - Return `None` for `SkipAggregationProbe` when `probe_ratio_threshold >= 1.0`, effectively disabling the feature since the ratio can never exceed `1.0`. ## Are these changes tested? Yes. Added `test_skip_aggregation_disabled_at_threshold_one` which sets threshold to `1.0` with 100% cardinality input and asserts that no rows are skipped. ## Are there any user-facing changes? Yes. Setting `skip_partial_aggregation_probe_ratio_threshold = 1.0` now reliably disables skip aggregation, matching the documented behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
