kumarUjjawal commented on code in PR #22719:
URL: https://github.com/apache/datafusion/pull/22719#discussion_r3353898713
##########
datafusion/functions-aggregate/src/array_agg.rs:
##########
@@ -916,8 +927,50 @@ impl Accumulator for DistinctArrayAggAccumulator {
Ok(ScalarValue::List(arr))
}
+ fn retract_batch(&mut self, values: &[ArrayRef]) -> Result<()> {
+ if values.is_empty() {
+ return Ok(());
+ }
+
+ assert_eq_or_internal_err!(values.len(), 1, "expects single batch");
+
+ let val = &values[0];
+ let nulls = if self.ignore_nulls {
+ val.logical_nulls()
+ } else {
+ None
+ };
+ let nulls = nulls.as_ref();
+
+ for i in 0..val.len() {
+ if nulls.is_some_and(|nulls| !nulls.is_valid(i)) {
+ continue;
+ }
+ let key = ScalarValue::try_from_array(val, i)?.compacted();
Review Comment:
since Hash/Eq are logical and an uncompacted key looks up identically, do we
need .compacted() here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
