alamb commented on issue #22739: URL: https://github.com/apache/datafusion/issues/22739#issuecomment-4621049791
> Proposed fixes > (a) Point fix in GroupValuesRows::emit. One reservation grow before convert_rows: > (b) Systemic alternative: OomGuardMemoryPool. R Thank you for working on this -- I think both improvements would be valuable. Also, it would be great to try and figure out how to more systematically find other issues that result in memory over commits (like could we run with a pool that compare the actual allocated memory to the declared memory and error if the delta got too high or something 🤔 ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
