alamb commented on code in PR #22751:
URL: https://github.com/apache/datafusion/pull/22751#discussion_r3355243422
##########
datafusion/physical-plan/Cargo.toml:
##########
@@ -76,6 +81,9 @@ datafusion-physical-expr = { workspace = true,
default-features = true }
datafusion-physical-expr-common = { workspace = true }
datafusion-proto-common = { workspace = true, optional = true }
datafusion-proto-models = { workspace = true, optional = true }
+# Optional heap profiler used by the `dhat-heap` feature for memory
Review Comment:
I am super worried about the long term cost of this dependency :
The crates page in https://crates.io/crates/dhat says
> Warning: This crate is experimental. It relies on implementation
techniques that are hard to keep working for 100% of configurations. It may
work fine for you, or it may crash, hang, or otherwise do the wrong thing. Its
maintenance is not a high priority of the author. Support requests such as
issues and pull requests may receive slow responses, or no response at all.
Sorry!
It also seems like the tests that need this are not actually run in CI /
automatically
Do we really need to add it in this PR?
Maybe we can keep the profiling tests in their own branch or something and
run them manually (or in an outside repo)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
