2010YOUY01 commented on code in PR #22729:
URL: https://github.com/apache/datafusion/pull/22729#discussion_r3356042629
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -499,6 +506,8 @@ impl PartialEq for PhysicalGroupBy {
#[expect(clippy::large_enum_variant)]
enum StreamType {
AggregateStream(AggregateStream),
+ InitialPartialHash(InitialPartialHashAggregateStream),
+ PartialFinalHash(PartialFinalHashAggregateStream),
GroupedHash(GroupedHashAggregateStream),
Review Comment:
Added comments in
[3184e00](https://github.com/apache/datafusion/pull/22729/commits/3184e0044c1468a4660f5c89063253d47077b344)
for 1. input/output schema 2. Incremental migration strategy for why
`GroupsHashAggregateStream` hasn't changed.
> For example is `GroupedHash` the same as InitialPartialHash?
`GroupedHash` is a reused path for `InitialPartial` and `ParitalFinal` and
many others, this might explain why changing things inside `GroupedHash` is
very hard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
