Rachelint commented on PR #22729: URL: https://github.com/apache/datafusion/pull/22729#issuecomment-4622619050
> The purpose of this refactor is to make that boundary explicit. With this split, the key blocked state-management changes (Accumulator + GroupValues) should only interact with the new dedicated stream, rather than being wired into the complex state machine in row_hash.rs. Make sense. Currently , it is actually very very hard to understand the state machine in `row_hash.rs`... > Yes I agree. I was thinking maybe https://github.com/apache/datafusion/pull/15591 can be updated after this refactor, if we can ensure the blocked Accumulator and GroupValues can only get planned into the new aggregate streams in this refactor, and the old row_hash.rs won't get affected, that change would be easier to review. Sounds good, #15591 still not apply the blocked logic into splling path and others, and I think really hard if we do it in the old logic... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
