adriangb commented on code in PR #22704: URL: https://github.com/apache/datafusion/pull/22704#discussion_r3357075493
########## benchmarks/sql_benchmarks/predicate_eval/predicate_eval.suite: ########## @@ -0,0 +1,2 @@ +name = "predicate_eval" +description = "Implementation-agnostic micro-benchmark suite for conjunctive (AND) filter evaluation. Characterises FilterExec along the axes that drive any predicate-ordering / AQE system: per-predicate cost and selectivity, the cost-weighted (cost/(1-sel)) interaction, conjunct count, string-column width, row count, predicate correlation, selectivity drift, nulls, and a pure-overhead control. Subgroups (select with BENCH_SUBGROUP): costsel, cost, selectivity, cardinality, width, scale, neutral, correlation, drift, nulls. The suite measures DataFusion's built-in left-deep AND short-circuit by default and sets no engine config of its own; toggle a reordering system under test with its native DATAFUSION_* env var (the harness reads SessionConfig::from_env), e.g. DATAFUSION_EXECUTION_ADAPTIVE_FILTER_REORDERING=true. Size synthetic data with PRED_ROWS and string-column width with PRED_FILL." Review Comment: addressed, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
