mbutrovich commented on code in PR #4305: URL: https://github.com/apache/datafusion-comet/pull/4305#discussion_r3359026111
########## docs/source/user-guide/latest/compatibility/json.md: ########## @@ -0,0 +1,55 @@ +<!--- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + +http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +# JSON Compatibility + +Comet can evaluate JSON expressions (`get_json_object`, `from_json`, `to_json`) +two ways: + +- **Codegen dispatcher (default):** Spark's own `doGenCode` for the expression + runs inside the Comet pipeline (via Comet's Arrow-direct codegen dispatcher), + giving byte-exact compatibility with Spark at the cost of a JNI roundtrip per + batch. This rides the codegen dispatcher + (`spark.comet.exec.scalaUDF.codegen.enabled`, enabled by default); if the + dispatcher is disabled, the operator falls back to Spark. +- **Native (rust) path:** the native DataFusion implementation. Faster, but has Review Comment: ```suggestion - **Native (Rust) path:** the native DataFusion implementation. Faster, but has ``` Can be in a followup since we don't want to trigger CI, but Rust should be capitalized. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
