pchintar commented on PR #22764: URL: https://github.com/apache/datafusion/pull/22764#issuecomment-4629253415
> @pchintar left some comments let me know what you think. @kumarUjjawal Thanks for pointing this out. I updated the retract logic in both the covariance and variance accumulators to explicitly reset their internal state when the final valid row is removed from the sliding window. I also expanded the regression coverage to exercise the specific edge cases involved here: * row removals that transition the window to an empty state, * accumulation after a reset, * NULL-gap scenarios where valid rows leave and later re-enter the frame, * rows where only one covariance input is NULL (invalid pairs should be ignored), * direct variance/stddev coverage for the same retract-to-empty path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
