edmondop commented on code in PR #11013:
URL: https://github.com/apache/datafusion/pull/11013#discussion_r1701819442
##########
datafusion/functions-aggregate/src/min_max.rs:
##########
@@ -914,69 +888,56 @@ impl Accumulator for SlidingMaxAccumulator {
}
}
-/// MIN aggregate expression
-#[derive(Debug, Clone)]
+#[derive(Debug)]
pub struct Min {
- name: String,
- data_type: DataType,
- nullable: bool,
- expr: Arc<dyn PhysicalExpr>,
+ signature: Signature,
+ aliases: Vec<String>,
}
impl Min {
- /// Create a new MIN aggregate function
- pub fn new(
- expr: Arc<dyn PhysicalExpr>,
- name: impl Into<String>,
- data_type: DataType,
- ) -> Self {
+ pub fn new() -> Self {
Self {
- name: name.into(),
- expr,
- data_type: min_max_aggregate_data_type(data_type),
- nullable: true,
+ signature: Signature::user_defined(Volatility::Immutable),
+ aliases: vec!["min".to_owned()],
}
}
}
-impl AggregateExpr for Min {
- /// Return a reference to Any that can be used for downcasting
- fn as_any(&self) -> &dyn Any {
+impl Default for Min {
+ fn default() -> Self {
+ Self::new()
+ }
+}
+
+impl AggregateUDFImpl for Min {
+ fn as_any(&self) -> &dyn std::any::Any {
self
}
- fn field(&self) -> Result<Field> {
- Ok(Field::new(
- &self.name,
- self.data_type.clone(),
- self.nullable,
- ))
+ fn name(&self) -> &str {
+ "MIN"
Review Comment:
I logged this https://github.com/apache/datafusion/issues/11779 I am not
sure we should lowercase this or make the other UDF uppercase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
