github-actions[bot] commented on PR #22777: URL: https://github.com/apache/datafusion/pull/22777#issuecomment-4633843649
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v53.1.0 (current) Built [ 103.808s] (current) Parsing datafusion v53.1.0 (current) Parsed [ 0.037s] (current) Building datafusion v53.1.0 (baseline) Built [ 100.980s] (baseline) Parsing datafusion v53.1.0 (baseline) Parsed [ 0.039s] (baseline) Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.962s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 207.764s] datafusion Building datafusion-common v53.1.0 (current) Built [ 34.680s] (current) Parsing datafusion-common v53.1.0 (current) Parsed [ 0.065s] (current) Building datafusion-common v53.1.0 (baseline) Built [ 34.111s] (baseline) Parsing datafusion-common v53.1.0 (baseline) Parsed [ 0.063s] (baseline) Checking datafusion-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.031s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 71.215s] datafusion-common Building datafusion-expr v53.1.0 (current) Built [ 26.907s] (current) Parsing datafusion-expr v53.1.0 (current) Parsed [ 0.078s] (current) Building datafusion-expr v53.1.0 (baseline) Built [ 27.096s] (baseline) Parsing datafusion-expr v53.1.0 (baseline) Parsed [ 0.080s] (baseline) Checking datafusion-expr v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 1.774s] 223 checks: 221 pass, 1 fail, 1 warn, 30 skip --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/enum_variant_added.ron Failed in: variant Partitioning:Range in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:4450 variant Partitioning:Range in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:4450 --- warning partial_ord_enum_variants_reordered: enum variants reordered in #[derive(PartialOrd)] enum --- Description: A public enum that derives PartialOrd had its variants reordered. #[derive(PartialOrd)] uses the enum variant order to set the enum's ordering behavior, so this change may break downstream code that relies on the previous order. ref: https://doc.rust-lang.org/std/cmp/trait.PartialOrd.html#derivable impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/partial_ord_enum_variants_reordered.ron Failed in: Partitioning::DistributeBy moved from position 3 to 4, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:4452 Partitioning::DistributeBy moved from position 3 to 4, in /home/runner/work/datafusion/datafusion/datafusion/expr/src/logical_plan/plan.rs:4452 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 57.611s] datafusion-expr Building datafusion-physical-expr v53.1.0 (current) Built [ 28.895s] (current) Parsing datafusion-physical-expr v53.1.0 (current) Parsed [ 0.051s] (current) Building datafusion-physical-expr v53.1.0 (baseline) Built [ 28.985s] (baseline) Parsing datafusion-physical-expr v53.1.0 (baseline) Parsed [ 0.054s] (baseline) Checking datafusion-physical-expr v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.541s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/struct_missing.ron Failed in: struct datafusion_physical_expr::SplitPoint, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a5cdb2ad55310fc69c38f794c984085911be093f/datafusion/physical-expr/src/partitioning.rs:225 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 59.682s] datafusion-physical-expr Building datafusion-proto v53.1.0 (current) Built [ 59.909s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.019s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 60.061s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.022s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.375s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 122.088s] datafusion-proto Building datafusion-substrait v53.1.0 (current) Built [ 343.611s] (current) Parsing datafusion-substrait v53.1.0 (current) Parsed [ 0.018s] (current) Building datafusion-substrait v53.1.0 (baseline) Built [ 344.503s] (baseline) Parsing datafusion-substrait v53.1.0 (baseline) Parsed [ 0.021s] (baseline) Checking datafusion-substrait v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.303s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 690.609s] datafusion-substrait ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
