jayzhan211 commented on code in PR #11776:
URL: https://github.com/apache/datafusion/pull/11776#discussion_r1701855415
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1908,9 +1648,9 @@ pub fn create_aggregate_expr_and_maybe_filter(
) -> Result<AggregateExprWithOptionalArgs> {
// unpack (nested) aliased logical expressions, e.g. "sum(col) as total"
let (name, e) = match e {
- Expr::Alias(Alias { expr, name, .. }) => (name.clone(), expr.as_ref()),
- Expr::AggregateFunction(_) =>
(e.display_name().unwrap_or(physical_name(e)?), e),
- _ => (physical_name(e)?, e),
+ Expr::Alias(Alias { expr, name, .. }) => (Some(name.clone()),
expr.as_ref()),
+ Expr::AggregateFunction(_) => (None, e),
Review Comment:
I think `e.display_name()` should be kept
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
