coderfender commented on code in PR #4429:
URL: https://github.com/apache/datafusion-comet/pull/4429#discussion_r3367815688
##########
spark/src/main/scala/org/apache/spark/sql/comet/operators.scala:
##########
@@ -1924,6 +1924,158 @@ trait CometHashJoin {
}
}
+case class CometBroadcastNestedLoopJoinExec(
Review Comment:
Verified DF's `NestedLoopJoinExec` uses the same `BuildProbeJoinMetrics`
shape as `HashJoinExec` So instead of duplicating the metric map, renamed
`hashJoinMetrics` to `joinMetrics` in `CometMetricNode.scala`, updated the two
existing call sites (BHJ + SHJ case classes), and added a new override
CometBroadcastNestedLoopJoinExec to leverage the same metric report function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
