viirya commented on code in PR #765:
URL: https://github.com/apache/datafusion-comet/pull/765#discussion_r1701981437
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -2931,8 +2931,8 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
msg = s"unsupported Spark partitioning expressions: $expressions"
}
supported
- case SinglePartition => true
- case RoundRobinPartitioning(_) => true
+ case SinglePartition => inputs.forall(attr =>
supportedDataType(attr.dataType))
+ case RoundRobinPartitioning(_) => inputs.forall(attr =>
supportedDataType(attr.dataType))
Review Comment:
I brought this regression in #760. We still need to check input data types
for SinglePartition, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
