manuzhang opened a new pull request, #4608: URL: https://github.com/apache/datafusion-comet/pull/4608
Add CometCastSuite coverage for array-of-struct casts, struct fields containing arrays, and deeply nested struct casts to both struct and string targets. ## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #4248. ## Rationale for this change `CometCastSuite` covered flat struct casts and primitive array casts, but it did not directly exercise recursive cast behavior for arrays of structs, structs containing arrays, or deeper nested structs. These cases are supported recursively and should have focused regression coverage. ## What changes are included in this PR? This adds `CometCastSuite` coverage for: - `Array(Struct(...))` to `Array(Struct(...))` with field type changes. - `Array(Struct(...))` to `String`. - `Struct` with an `Array` field to another `Struct` with the inner array element type cast. - Deeply nested `Struct(Struct(Struct(...)))` casts to both `Struct` and `String`. The tests use Parquet-backed inputs through `testSingleLineQuery` so the native Comet path is exercised. ## How are these changes tested? - `make core` - `./mvnw test -Pjdk17 -Dtest=none -Dsuites=org.apache.comet.CometCastSuite` --- Co-authored-by: @codex -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
