martin-g commented on code in PR #22815:
URL: https://github.com/apache/datafusion/pull/22815#discussion_r3373938132
##########
datafusion/functions-aggregate/src/approx_distinct.rs:
##########
@@ -1037,16 +1058,18 @@ fn is_hll_groups_type(data_type: &DataType) -> bool {
}
#[cfg(test)]
-mod groups_tests {
+mod tests {
use super::*;
+ use arrow::array::{AsArray, Int64Array, StringViewArray};
+ use std::sync::Arc;
+
+ // A string longer than the 12-byte inline limit
+ const LONG: &str = "this string is definitely longer than twelve bytes";
- /// Hash a value the same way the accumulators do.
fn h(v: u64) -> u64 {
HLL_HASH_STATE.hash_one(v)
}
- /// Reference count: fold the given distinct hashes straight into a dense
- /// HyperLogLog. The grouped sketch must agree with this exactly.
Review Comment:
Why the docs are removed ?
The functions are private but the information is useful, no ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
