martin-g commented on code in PR #22829:
URL: https://github.com/apache/datafusion/pull/22829#discussion_r3375996768
##########
datafusion/execution/src/cache/file_metadata_cache.rs:
##########
@@ -25,9 +25,18 @@ use crate::cache::{
lru_queue::LruQueue,
};
+/// Internal cache value: the entry plus its precomputed memory size, so we
+/// don't have to call [`FileMetadata::memory_size`] (which walks the entire
+/// metadata structure) on every put / remove / eviction.
Review Comment:
```suggestion
/// metadata structure) on every put / remove / eviction.
///
/// [`FileMetadata::memory_size`]:
https://docs.rs/datafusion/latest/datafusion/execution/cache/cache_manager/trait.FileMetadata.html#tymethod.memory_size
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
