Jefffrey commented on PR #22832: URL: https://github.com/apache/datafusion/pull/22832#issuecomment-4654998740
both of these spark classes inherit from `UnaryMathExpression`: - https://github.com/apache/spark/blob/0849776499c9d223ee6fa5a2dd53b999f6f39818/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala#L527-L532 - https://github.com/apache/spark/blob/0849776499c9d223ee6fa5a2dd53b999f6f39818/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala#L754-L758 which by default has `nullable = true` https://github.com/apache/spark/blob/0849776499c9d223ee6fa5a2dd53b999f6f39818/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala#L66-L87 are we sure we're meant to have output nullability depend on the input? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
