LiaCastaneda commented on code in PR #22689:
URL: https://github.com/apache/datafusion/pull/22689#discussion_r3379042902


##########
datafusion/sqllogictest/test_files/map/transform_values.slt:
##########


Review Comment:
   I think it would also be worth adding a test case for:
   - Empty map
   - Mixed rows w empty map, null rows, populated maps (to double check the 
offset handling works)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to