alamb commented on code in PR #11781: URL: https://github.com/apache/datafusion/pull/11781#discussion_r1702168887
########## datafusion/sqllogictest/test_files/aggregate.slt: ########## @@ -4536,19 +4536,14 @@ EXPLAIN SELECT DISTINCT c3 FROM aggregate_test_100 group by c3 limit 5; logical_plan 01)Limit: skip=0, fetch=5 02)--Aggregate: groupBy=[[aggregate_test_100.c3]], aggr=[[]] -03)----Aggregate: groupBy=[[aggregate_test_100.c3]], aggr=[[]] Review Comment: These certainly look like bettr plans to me. However, I wonder if these changes now mean the query doesn't fulfill the original intent of the tests ```sql # # Push limit into distinct group-by aggregation tests # ``` Therefore I wonder if we should add another test like ``` EXPLAIN SELECT DISTINCT c3, min(c1) FROM aggregate_test_100 group by c3 limit 5; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
