alamb opened a new issue, #11788:
URL: https://github.com/apache/datafusion/issues/11788

   ### Is your feature request related to a problem or challenge?
   
   While trying to debug a CI failure on 
https://github.com/apache/datafusion/pull/11627 from @korowa  the message 
doesn't explain what is wrong
   
   CI failure: 
https://github.com/apache/datafusion/actions/runs/10204347289/job/28280296775?pr=11627
   
   Output error:
   ```
   Run # If you encounter an error with any of the commands below
   Fetching index
   Verifying the Minimum Supported Rust Version (MSRV) for toolchain 
x86_64-unknown-linux-gnu
   Using check command cargo check
      Failed check command cargo check didn't succeed
   Crate source was found to be incompatible with its MSRV '1.76.0', as defined 
in '/__w/datafusion/datafusion/datafusion/core/Cargo.toml'
   Error: Process completed with exit code 1.
   
   ```
   
   
   ### Describe the solution you'd like
   
   I would like a failing CI run to explain what is wrong / how to fix it
   
   ### Describe alternatives you've considered
   
   We could add the `--log-target` option to get aprintout to stdout
   
   
   ```
   andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion/datafusion/core$ 
cargo msrv --verify --log-target stdout
   2024-08-02T18:29:20.159773Z  INFO cargo_msrv: initializing 
cargo_msrv_version="0.15.1"
   Fetching index
   2024-08-02T18:29:20.159807Z  INFO cargo_msrv: fetching index 
source="rust-changelog"
   2024-08-02T18:29:20.160236Z  INFO cargo_msrv: running action 
action="verify-msrv"
   Verifying the Minimum Supported Rust Version (MSRV) for toolchain 
aarch64-apple-darwin
   Using check command cargo check
    ⠁                                
░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░
 00:00:00
   2024-08-02T18:29:20.160691Z  INFO cargo_msrv::check: 
ignore_lockfile_enabled=false
   2024-08-02T18:29:20.160715Z  INFO download{self=ToolchainDownloader { 
reporter: toolchain = aarch64-apple-darwin, cmd = cargo check }}: 
cargo_msrv::down
    ⠙ Done Bad check for 1.76.0      
░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░
 00:00:00
   2024-08-02T18:29:20.766327Z  INFO cargo_msrv::check: try_building run failed 
toolchain=ToolchainSpec { version: Version { major: 1, minor: 76, patch: 0 }, 
target: "aarch64-apple-darwin", spec: OnceCell("1.76.0-aarch64-apple-darwin") } 
stderr="warning: /Users/andrewlamb/Software/datafusion/Cargo.toml: unused 
manifest key: workspace.lints.rust.unexpected_cfgs.check-cfg\n    Checking 
datafusion-physical-expr-common v40.0.0 
(/Users/andrewlamb/Software/datafusion/datafusion/physical-expr-common)\nerror[E0716]:
 temporary value dropped while borrowed\n   --> 
datafusion/physical-expr-common/src/aggregate/groups_accumulator/prim_op.rs:167:18\n
    |\n151 |         let values = match opt_filter {\n    |             ------ 
borrow later stored here\n...\n167 |                 
&PrimitiveArray::<T>::new(values_buf, nulls_buf).with_data_type(dt)\n    |      
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 
creates a temporary value which is freed while still in use\n1
 68 |             }\n    |             - temporary value is freed at the end of 
this statement\n    |\n    = note: consider using a `let` binding to create a 
longer lived value\n\nFor more information about this error, try `rustc 
--explain E0716`.\nerror: could not compile `datafusion-physical-expr-common` 
(lib) due to 1 previous error\n" cmd="1.76.0-aarch64-apple-darwin
      Done Bad check for 1.76.0      
█████████████████████████████████████████████████████████████████████████████████████████████████████████████
 00:00:00
      Failed check command cargo check didn't succeed
   Crate source was found to be incompatible with its MSRV '1.76.0', as defined 
in '/Users/andrewlamb/Software/datafusion/datafusion/core/Cargo.toml'
   ```
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to