github-actions[bot] commented on PR #22860: URL: https://github.com/apache/datafusion/pull/22860#issuecomment-4663993686
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-execution v54.0.0 (current) Built [ 32.768s] (current) Parsing datafusion-execution v54.0.0 (current) Parsed [ 0.026s] (current) Building datafusion-execution v54.0.0 (baseline) Built [ 32.574s] (baseline) Parsing datafusion-execution v54.0.0 (baseline) Parsed [ 0.026s] (baseline) Checking datafusion-execution v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.242s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-item-signature impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_missing.ron Failed in: method try_resize of trait MemoryPool, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/execution/src/memory_pool/mod.rs:233 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 66.977s] datafusion-execution Building datafusion-sqllogictest v54.0.0 (current) Built [ 167.299s] (current) Parsing datafusion-sqllogictest v54.0.0 (current) Parsed [ 0.022s] (current) Building datafusion-sqllogictest v54.0.0 (baseline) Built [ 166.253s] (baseline) Parsing datafusion-sqllogictest v54.0.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-sqllogictest v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.098s] 223 checks: 219 pass, 4 fail, 0 warn, 30 skip --- failure feature_missing: package feature removed or renamed --- Description: A feature has been removed from this package's Cargo.toml. This will break downstream crates which enable that feature. ref: https://doc.rust-lang.org/cargo/reference/semver.html#cargo-feature-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/feature_missing.ron Failed in: feature memory-accounting in the package's Cargo.toml --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/function_missing.ron Failed in: function datafusion_sqllogictest::local_balance, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:196 function datafusion_sqllogictest::set_default_budget, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:147 function datafusion_sqllogictest::account_balance, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:189 function datafusion_sqllogictest::set_account_balance, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:168 function datafusion_sqllogictest::current_context_id, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:127 function datafusion_sqllogictest::memory_tracker_limit, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:184 function datafusion_sqllogictest::default_budget, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:153 function datafusion_sqllogictest::next_context_id, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:99 function datafusion_sqllogictest::settle_thread_local, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:202 function datafusion_sqllogictest::set_thread_context_id, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:105 function datafusion_sqllogictest::set_memory_tracker_limit, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:179 function datafusion_sqllogictest::reset_account_to_default, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:162 --- failure pub_module_level_const_missing: pub module-level const is missing --- Description: A public const is missing or renamed ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/pub_module_level_const_missing.ron Failed in: SLT_TARGET_PARTITIONS in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/test_context.rs:75 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/struct_missing.ron Failed in: struct datafusion_sqllogictest::OverdraftPanic, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:140 struct datafusion_sqllogictest::AccountingAllocator, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting.rs:260 struct datafusion_sqllogictest::AccountingMemoryPool, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/cb69f4d3e0dab9b0e8b8e8c73be74ec6b43aa8b7/datafusion/sqllogictest/src/accounting_pool.rs:45 Summary semver requires new major version: 4 major and 0 minor checks failed Finished [ 336.134s] datafusion-sqllogictest ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
