Jefffrey commented on PR #22835:
URL: https://github.com/apache/datafusion/pull/22835#issuecomment-4667206638
ive only skimmed this, but i wonder how we'll enforce/ensure we remember to
apply this normalization each time for different operation/functions/execution
paths 🤔
for example, this fix isn't applied to `array_replace` (testing on main
after this merged):
```sql
> select array_replace([0.0, -0.0], 0.0, 1.0);
+-------------------------------------------------------------------------+
| array_replace(make_array(Float64(0),Float64(-0)),Float64(0),Float64(1)) |
+-------------------------------------------------------------------------+
| [1.0, -0.0] |
+-------------------------------------------------------------------------+
1 row(s) fetched.
Elapsed 0.003 seconds.
```
postgres for comparison:
```sql
postgres=# select array_replace(ARRAY[0.0, -0.0], 0.0, 1.0);
array_replace
---------------
{1.0,1.0}
(1 row)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
