ariel-miculas commented on PR #22862: URL: https://github.com/apache/datafusion/pull/22862#issuecomment-4668467759
> I'm wondering whether you have a better alternative in mind, or if there are other concerns that would suggest we should not merge this? For this particular issue I think `get_sliced_size` would be a better option, see: https://github.com/apache/datafusion/issues/22526#issuecomment-4621836931 Another concern I have is that operators should follow the same approach for reserving RecordBatches. As I mentioned before, this issue applies to other downstream consumers of HashAggregate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
