alamb commented on PR #11627: URL: https://github.com/apache/datafusion/pull/11627#issuecomment-2266157111
Here are my benchmarks for a 16 core machine -- 5%-10% faster on some queries ```shell Benchmark clickbench_1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main_base ┃ skip-partial-aggregation ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 0.68ms │ 0.68ms │ no change │ │ QQuery 1 │ 70.21ms │ 68.15ms │ no change │ │ QQuery 2 │ 120.46ms │ 125.21ms │ no change │ │ QQuery 3 │ 135.06ms │ 127.15ms │ +1.06x faster │ │ QQuery 4 │ 983.92ms │ 973.17ms │ no change │ │ QQuery 5 │ 1114.48ms │ 1037.79ms │ +1.07x faster │ │ QQuery 6 │ 66.65ms │ 66.50ms │ no change │ │ QQuery 7 │ 71.79ms │ 71.29ms │ no change │ │ QQuery 8 │ 1481.39ms │ 1498.25ms │ no change │ │ QQuery 9 │ 1320.77ms │ 1362.29ms │ no change │ │ QQuery 10 │ 456.17ms │ 452.00ms │ no change │ │ QQuery 11 │ 489.17ms │ 485.89ms │ no change │ │ QQuery 12 │ 1184.59ms │ 1139.32ms │ no change │ │ QQuery 13 │ 2406.50ms │ 2147.44ms │ +1.12x faster │ │ QQuery 14 │ 1601.35ms │ 1552.84ms │ no change │ │ QQuery 15 │ 1112.00ms │ 1057.08ms │ no change │ │ QQuery 16 │ 2925.99ms │ 2895.28ms │ no change │ │ QQuery 17 │ 2880.80ms │ 2810.83ms │ no change │ │ QQuery 18 │ 5802.98ms │ 5656.43ms │ no change │ │ QQuery 19 │ 124.49ms │ 121.22ms │ no change │ │ QQuery 20 │ 1631.25ms │ 1667.78ms │ no change │ │ QQuery 21 │ 2006.10ms │ 1988.89ms │ no change │ │ QQuery 22 │ 4850.25ms │ 4410.90ms │ +1.10x faster │ │ QQuery 23 │ 11369.51ms │ 10971.88ms │ no change │ │ QQuery 24 │ 754.02ms │ 712.13ms │ +1.06x faster │ │ QQuery 25 │ 680.13ms │ 642.36ms │ +1.06x faster │ │ QQuery 26 │ 828.70ms │ 794.37ms │ no change │ │ QQuery 27 │ 2522.10ms │ 2498.20ms │ no change │ │ QQuery 28 │ 14499.13ms │ 14418.23ms │ no change │ │ QQuery 29 │ 565.98ms │ 556.15ms │ no change │ │ QQuery 30 │ 1323.70ms │ 1262.11ms │ no change │ │ QQuery 31 │ 1661.08ms │ 1606.92ms │ no change │ │ QQuery 32 │ 7572.40ms │ 7557.61ms │ no change │ │ QQuery 33 │ 5006.39ms │ 4946.64ms │ no change │ │ QQuery 34 │ 5048.05ms │ 4993.11ms │ no change │ │ QQuery 35 │ 1847.44ms │ 1815.02ms │ no change │ │ QQuery 36 │ 322.02ms │ 322.06ms │ no change │ │ QQuery 37 │ 220.67ms │ 206.19ms │ +1.07x faster │ │ QQuery 38 │ 193.30ms │ 191.14ms │ no change │ │ QQuery 39 │ 1018.81ms │ 992.98ms │ no change │ │ QQuery 40 │ 88.71ms │ 86.35ms │ no change │ │ QQuery 41 │ 79.16ms │ 82.48ms │ no change │ │ QQuery 42 │ 93.37ms │ 96.15ms │ no change │ └──────────────┴────────────┴──────────────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (main_base) │ 88531.75ms │ │ Total Time (skip-partial-aggregation) │ 86468.47ms │ │ Average Time (main_base) │ 2058.88ms │ │ Average Time (skip-partial-aggregation) │ 2010.89ms │ │ Queries Faster │ 7 │ │ Queries Slower │ 0 │ │ Queries with No Change │ 36 │ └─────────────────────────────────────────┴────────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org