rluvaton commented on code in PR #18910:
URL: https://github.com/apache/datafusion/pull/18910#discussion_r3388676812
##########
datafusion/common/src/error.rs:
##########
@@ -1304,14 +1281,8 @@ mod test {
ok_result()
}
- let err = check().unwrap_err();
- assert_snapshot!(
- err.to_string(),
- @r"
- Internal error: Assertion failed: false: custom 42.
- This issue was likely caused by a bug in DataFusion's code. Please
help us to resolve this by filing a bug report in our issue tracker:
https://github.com/apache/datafusion/issues
- "
- );
+ let err = check().unwrap_err().strip_backtrace();
+ assert!(err.starts_with("Internal error: Assertion failed: false:
custom 42"));
}
Review Comment:
Updated the code to use starts_with like done in the original pr that add
the backtrace:
-
https://github.com/apache/datafusion/pull/7434/changes#diff-bdc4c06f901055976f11cc28c8d3d75860c59ecb9d02d795b576145dc5e8b3a3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
