alamb commented on PR #22871: URL: https://github.com/apache/datafusion/pull/22871#issuecomment-4673486632
> On the first point: I kept the implementation in user_defined_plan.rs rather than deleting the file, because the module has grown to also test user defined plan invariants (InvariantMock, the topk_invariants* tests). Those tests are not documentation and would be lost on a full delete. Happy to move them elsewhere or delete more aggressively if you'd prefer. Would you be willing to move them, as a follow on PR, to unit tests (if they aren't already covered)? I agree that piggy backing invariant tests in other examples makes them harder to follow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
