JarroVGIT opened a new pull request, #1857:
URL: https://github.com/apache/datafusion-ballista/pull/1857
# Which issue does this PR close?
Closes #1856
# Rationale for this change
I really just wanted dark mode, and the dependencies seemed a bit dated
(Python 3.10 is EOL later this year, so a bump couldn't hurt). It also brings
it more in line with the official Datafusion docs, and I now realize that I
assumed that to be something positive while this project might actually want to
pursue its own style to set it apart from the Datafusion website.
# What changes are included in this PR?
- Python bump in Github Action
- Sfinx and theme plugin version bump (automatically brings the dark mode
toggle)
- Theme overrides update (CSS)
- Update some HTML with new API from Sfinx and enable the top navbar (which
holds the dark mode toggle)
- Make sure the logo is nice in both light and dark mode.
I have ran it locally and clicked around, didn't see any visual glitches but
admittedly I have only tested it in Firefox.
**Disclaimer:** The changes were AI generated based on the Datafusion
repository, manually reviewed by me. I would normally submit AI generated PR's
but this is the type of stuff that I guess I want AI to take it out of my hands
to be honest. Apologies if this is against policy!
# Are there any user-facing changes?
Not code-wise, but documentation wise certainly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
