lyne7-sc opened a new pull request, #22902:
URL: https://github.com/apache/datafusion/pull/22902
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #22901.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
A query whose subquery becomes a mark join (`LeftMark`/`RightMark`) can
panic during the `ProjectionPushdown` physical optimization with an internal
assertion error.
The pushdown helper `try_pushdown_through_join` assumes the join output
schema is the plain concatenation of its two children (`left ++ right`) and
uses `join_table_borders` to split the projected columns into a left group and
a right group by column index. Mark joins break this assumption: they append an
extra `mark` boolean column that does not originate from either child, so the
column-index split misroutes columns to the wrong side and the subsequent
child-projection rewrite fails its name-match assertion.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
In `HashJoinExec::try_swapping_with_projection` and
`NestedLoopJoinExec::try_swapping_with_projection`, skip the
`try_pushdown_through_join` path for mark joins (`LeftMark`/`RightMark`) and
fall through to embedding the projection into the join instead.
## Are these changes tested?
Yes.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
## Are there any user-facing changes?
Yes, only bug fixes.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
