martin-g commented on code in PR #1850:
URL:
https://github.com/apache/datafusion-ballista/pull/1850#discussion_r3394288614
##########
ballista-cli/src/tui/infrastructure/config.rs:
##########
@@ -81,10 +91,10 @@ impl Settings {
.format(FileFormat::Yaml)
.required(false),
)
- // Add in settings from the environment (with a prefix of
BALLISTA_)
- // E.g. `BALLISTA_SCHEDULER_URL=http://localhost:50051
ballista_cli`
+ // Add in settings from the environment (with a prefix of
`BALLISTA`.)
+ // E.g. `BALLISTA__SCHEDULER__URL=http://localhost:50051
ballista_cli`
Review Comment:
Because some of the properties use underscore, e.g. `table_header` and
`app_background` and the `config` crate cannot resolve
`BALLISTA_THEME_OVERRIDES_TABLE_HEADER_BG=color`
There was no such issue with the top level settings.
BALLISTA_DATA_RELOAD_INTERVAL_MS=123 properly sets the
`data_reload_interval_ms` setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
