AdamGS commented on PR #22604: URL: https://github.com/apache/datafusion/pull/22604#issuecomment-4684223192
Not that I can remember, and the only thing that jumps out to me is the re-writing of the `TableSchema` in `table_schema_with_row_index_col` is a bit awkward because there's no way to turn a `TableSchema` to a builder or otherwise mutate it which I remember being an issue in #22026 as well. I might try and figure out a nicer API in a follow up PR, but I'm not sure how much code paths actually do something like it, maybe there's no real benefit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
