github-actions[bot] commented on PR #22921: URL: https://github.com/apache/datafusion/pull/22921#issuecomment-4687105330
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-common v54.0.0 (current) Built [ 34.845s] (current) Parsing datafusion-common v54.0.0 (current) Parsed [ 0.064s] (current) Building datafusion-common v54.0.0 (baseline) Built [ 32.350s] (baseline) Parsing datafusion-common v54.0.0 (baseline) Parsed [ 0.065s] (baseline) Checking datafusion-common v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 1.079s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_requires_different_generic_type_params: trait method now requires a different number of generic type parameters --- Description: A trait method now requires a different number of generic type parameters than it used to. Calls or implementations of this trait method using the previous number of generic types will be broken. ref: https://doc.rust-lang.org/reference/items/generics.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.48.0/src/lints/trait_method_requires_different_generic_type_params.ron Failed in: HashValue::hash_one (0 -> 1 generic types) in /home/runner/work/datafusion/datafusion/datafusion/common/src/hash_utils.rs:208 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 70.793s] datafusion-common Building datafusion-functions-aggregate v54.0.0 (current) Built [ 29.588s] (current) Parsing datafusion-functions-aggregate v54.0.0 (current) Parsed [ 0.047s] (current) Building datafusion-functions-aggregate v54.0.0 (baseline) Built [ 30.011s] (baseline) Parsing datafusion-functions-aggregate v54.0.0 (baseline) Parsed [ 0.052s] (baseline) Checking datafusion-functions-aggregate v54.0.0 -> v54.0.0 (no change; assume patch) Checked [ 0.287s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 61.106s] datafusion-functions-aggregate ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
