timsaucer commented on PR #107: URL: https://github.com/apache/datafusion-java/pull/107#issuecomment-4691139833
Heads-up from the foundation split (01-workspace-foundation): the RAT exclude `<exclude>**/META-INF/services/**</exclude>` was removed from the root `pom.xml` there because it was forward-referencing files that do not exist until this PR. This PR (04) is the first to add a `META-INF/services` registration file (`spark/src/main/resources/META-INF/services/org.apache.spark.sql.sources.DataSourceRegister`), which is a line-delimited FQCN list with no license header. Action required: re-add the exclude to the root `pom.xml` RAT `<excludes>` block in this PR, or `apache-rat:check` will flag the file as unapproved once 01 is rebased in. ```xml <!-- Spark DataSource SPI registration file (line-delimited FQCN list, no header) --> <exclude>**/META-INF/services/**</exclude> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
