korowa commented on code in PR #11789:
URL: https://github.com/apache/datafusion/pull/11789#discussion_r1702849340
##########
.github/workflows/rust.yml:
##########
@@ -566,18 +566,32 @@ jobs:
- name: Check datafusion
working-directory: datafusion/core
run: |
- # If you encounter an error with any of the commands below
- # it means some crate in your dependency tree has a higher
- # MSRV (Min Supported Rust Version) than the one specified
- # in the `rust-version` key of `Cargo.toml`. Check your
- # dependencies or update the version in `Cargo.toml`
- cargo msrv verify
+ # If you encounter an error with any of the commands below it means
+ # your code or some crate in the dependency tree has a higher MSRV
+ # (Min Supported Rust Version) than the one specified in the
+ # `rust-version` key of `Cargo.toml`.
+ #
+ # To reproduce:
+ # 1. Install the version of Rust that is failing. Example:
+ # rustup install 1.76.0
+ # 2. Run the command that failed with that version. Example:
+ # cargo +1.76.0 check -p datafusion
+ #
+ # To resolve, either:
+ # 1. Change your code to use older Rust features,
+ # 2. Revert dependency update
+ # 3. Update the MSRV version in `Cargo.toml`
+ #
+ # Please see the DataFusion Rust Version Compatibility Policy before
+ # updating Cargo.toml. You may have to update the code instead.
+ #
https://github.com/apache/datafusion/blob/main/README.md#rust-version-compatibility-policy
+ cargo msrv --verify --log-target stdout
- name: Check datafusion-substrait
working-directory: datafusion/substrait
- run: cargo msrv verify
+ run: cargo msrv --verify --log-target stdout
Review Comment:
`--verify` flag has deprecation note in `cargo msrv --help`, so maybe it's
better to continue using verify subcommand?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
