viirya commented on code in PR #774:
URL: https://github.com/apache/datafusion-comet/pull/774#discussion_r1702940940
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometWindowExec.scala:
##########
@@ -65,71 +65,27 @@ case class CometWindowExec(
sparkContext,
"number of partitions")) ++ readMetrics ++ writeMetrics
- override def supportsColumnar: Boolean = true
-
- protected override def doExecuteColumnar(): RDD[ColumnarBatch] = {
- val childRDD = child.executeColumnar()
-
- childRDD.mapPartitionsInternal { iter =>
- CometExec.getCometIterator(
- Seq(iter),
- getNativePlan(output, windowExpression, partitionSpec, orderSpec,
child).get)
- }
- }
-
override def outputOrdering: Seq[SortOrder] = child.outputOrdering
override def outputPartitioning: Partitioning = child.outputPartitioning
protected def withNewChildInternal(newChild: SparkPlan): SparkPlan =
this.copy(child = newChild)
-}
-
-object CometWindowExec {
- def getNativePlan(
Review Comment:
It also can improve performance as we don't need additional native/JVM
bridge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
