gene-bordegaray commented on code in PR #22969:
URL: https://github.com/apache/datafusion/pull/22969#discussion_r3420870274


##########
datafusion/catalog-listing/src/options.rs:
##########


Review Comment:
   cleanup for this comment



##########
datafusion/proto-models/proto/datafusion.proto:
##########
@@ -92,8 +92,8 @@ message ListingTableScanNode {
   datafusion_common.Schema schema = 5;
   repeated LogicalExprNode filters = 6;
   repeated PartitionColumn table_partition_cols = 7;
-  bool collect_stat = 8;
-  uint32 target_partitions = 9;
+  reserved 8; // was bool collect_stat
+  reserved 9; // was unit32 target_partitions

Review Comment:
   nit: `uint32`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to