alamb commented on code in PR #11803:
URL: https://github.com/apache/datafusion/pull/11803#discussion_r1703155568
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -223,7 +223,7 @@ fn create_physical_name(e: &Expr, is_first_expr: bool) ->
Result<String> {
create_function_physical_name(&fun.to_string(), false, args,
Some(order_by))
}
Expr::AggregateFunction(AggregateFunction {
- func_def,
+ func: func_def,
Review Comment:
nit is that we could rename the local variable to func as well for more
consistency
##########
datafusion/expr/src/expr.rs:
##########
@@ -674,7 +658,7 @@ impl AggregateFunction {
null_treatment: Option<NullTreatment>,
) -> Self {
Self {
- func_def: AggregateFunctionDefinition::UDF(udf),
+ func: udf,
Review Comment:
ditto here it could be even more consistent if all the names were the same
##########
datafusion/expr/src/expr.rs:
##########
@@ -627,22 +627,6 @@ impl Sort {
}
}
-#[derive(Debug, Clone, PartialEq, Eq, Hash)]
Review Comment:
๐ ๐งน
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
