saadtajwar commented on PR #22962: URL: https://github.com/apache/datafusion/pull/22962#issuecomment-4721235059
> Thanks, @saadtajwar , looks excellent! Are there any benchmarks that you could run, like clickbench with SIMULATE_LATENCY as I did here? [#21478 (comment)](https://github.com/apache/datafusion/pull/21478#issue-4226173998) Haven't looked if there's CSV support, JSON support was missing when I ran these tests (#21446) Thanks @ariel-miculas ! Hmm, I see the `tpch_csv` benchmark for multiple smaller CSV files, but I don't think this would invoke `AlignedBoundaryStream`...I can't seem to find any existing benchmark (including Clickbench w/ CSV support) that could exercise the CSV byte-range repartioning path - should I add one in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
