Rachelint commented on PR #15591: URL: https://github.com/apache/datafusion/pull/15591#issuecomment-4738875697
> > Marking as a draft as I don't think this one is ready to merge quite yet and I am trying to clean up the review / merge queue > > Yes, and I think the whole feature will be suitable to push forward after the aggregation refactoring. > > Howerver, actually to parts are included in this: > > * One part is about refactoring `GroupValues` and `GroupAccumulator` > * The other part is about applying the blocked logic in aggreagating > > How about we split this pr into twos or mores? And push forward the part one (`GroupValues` and `GroupAccumulator`) in parallel with the aggregation refactoring? @alamb @2010YOUY01 @ariel-miculas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
