zyuiop commented on code in PR #22999:
URL: https://github.com/apache/datafusion/pull/22999#discussion_r3434712962
##########
datafusion/sql/src/unparser/dialect.rs:
##########
@@ -333,6 +338,17 @@ pub enum CharacterLengthStyle {
CharacterLength,
}
+/// `DistinctFromStyle` to use for unparsing `IsDistinctFrom` and
`IsNotDistinctFrom` operators
+#[derive(Clone, Copy, PartialEq)]
+pub enum DistinctFromStyle {
+ /// DBMS supports `IS (NOT) DISTINCT FROM`
+ FullText,
+ /// DMBS supports equivalent operations via `<=>` and `<>`
+ DiamondOperators,
Review Comment:
Correct, I initially intended to use `<>` and after checking the docs more
carefully I noticed it was not equivalent.
I changed the comment and renamed the enum variant to `Spaceship`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
