manuzhang opened a new pull request, #4675:
URL: https://github.com/apache/datafusion-comet/pull/4675

   ## Which issue does this PR close?
   
   Part of #4248
   
   ## Rationale for this change
   
   Nested struct casts currently unwrap nested cast results while building the 
output `StructArray`. When a nested cast fails, such as an ANSI overflow inside 
a struct, that unwrap can panic instead of returning the cast failure as a 
normal DataFusion error.
   
   ## What changes are included in this PR?
   
   - Propagate nested struct cast errors through `DataFusionResult` instead of 
unwrapping.
   - Add coverage for nested struct-to-string casts, nested struct-to-struct 
casts, array cast ANSI overflow, and expected ANSI failures in the cast helper.
   
   ## How are these changes tested?
   
   Updated tests suites and added native UTs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to