andygrove commented on PR #4487: URL: https://github.com/apache/datafusion-comet/pull/4487#issuecomment-4742848357
Thanks for the epic PR @jordepic. I've started looking through it and using AI to help me comprehend and review this, since I am not an Iceberg expert. I noticed that this PR is creating directly from the `main` branch of your fork - I'd recommend creating a separate branch. I like this this functionality is disabled by default so users can opt-in while this goes through more testing. Could you share some performance numbers and explain how you are benchmarking this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
