goutamadwant commented on PR #23002: URL: https://github.com/apache/datafusion/pull/23002#issuecomment-4743105227
Thanks for the review @kosiew I pushed an update addressing both comments. For the symmetric right-side case, the unparser now emits a qualified passthrough `Projection(Join)` as a parenthesized nested join relation instead of a derived projection. That keeps the inner join aliases visible to the outer join condition without reintroducing the invalid alias scope. I also added a regression test for the right-side nested join case and simplified `TableAliasRewriter` so the rewrite condition is expressed once and the replacement column is constructed once. Ran locally all the tests and they look fine. Let me know if you any suggestions. thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
