comphead commented on code in PR #4674:
URL: https://github.com/apache/datafusion-comet/pull/4674#discussion_r3436799100
##########
spark/src/main/scala/org/apache/comet/serde/arithmetic.scala:
##########
@@ -83,18 +83,24 @@ trait MathBase {
false
}
+ def mathDataTypeSupportLevel(dt: DataType): SupportLevel =
+ if (supportedDataType(dt)) {
Review Comment:
btw we can make it more Spark like
Spark has `Expression.checkInputDataTypes` and `inputTypes` to check inputs
```
override def inputTypes: Seq[AbstractDataType] = Seq(NumericType,
IntegerType)
override def checkInputDataTypes(): TypeCheckResult
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
