alamb opened a new pull request, #23029: URL: https://github.com/apache/datafusion/pull/23029
## Which issue does this PR close? - N/A. ## Rationale for this change `datafusion_physical_plan::spill::spill_record_batch_by_size` was deprecated in DataFusion `46.0.0` in favor of `SpillManager::spill_record_batch_by_size`. The [API health policy deprecation guidelines](https://datafusion.apache.org/contributor-guide/api-health.html#deprecation-guidelines) say deprecated methods remain for 6 major versions or 6 months, whichever is longer. This API has exceeded that window, so this removes the deprecated wrapper. ## What changes are included in this PR? - Removes the deprecated `datafusion_physical_plan::spill::spill_record_batch_by_size` function. - Removes the now-unused `PathBuf` import from `spill`. - Adds an upgrade guide note for the removal and replacement API. ## Are these changes tested? Yes. - `cargo fmt --all -- --check` - `cargo check -p datafusion-physical-plan` - `cargo test -p datafusion-physical-plan spill` - `cargo clippy --all-targets --all-features -- -D warnings` ## Are there any user-facing changes? Yes. This removes a public Rust API that was deprecated in DataFusion `46.0.0`. Downstream users should migrate to `datafusion_physical_plan::spill::SpillManager::spill_record_batch_by_size`. This is an API change and should be labeled `api-change`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
